♻️Minor refactor for amp-orientation-observer
#24812
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sparhami
suggested changes
Sep 30, 2019
|
|
||
| /** @private {Array} */ | ||
| this.gammaSmoothingPoints_ = []; | ||
| /** @private {{beta: Array, alpha: Array, gamma: Array}} */ |
| gamma: DEFAULT_REST_VALUES.gamma, | ||
| }; | ||
|
|
||
| /** @private {{beta: Array, alpha: Array, gamma: Array}} */ |
| this.betaRange_ = this.parseAttributes_('beta-range', this.betaRange_); | ||
| this.gammaRange_ = this.parseAttributes_('gamma-range', this.gammaRange_); | ||
| AXES.forEach(axis => { | ||
| this.range_[axis] = this.parseAttributes_( |
There was a problem hiding this comment.
I don't think this will work with property renaming, since the properties on this.range_ will be renamed to things like a and b.
To get around this, you could do something like:
/** @private {!Object<string, !Array<number>>} */
this.range_ = {
alpha: [0, 360],
};Alternatively, you can do this using arrays, and use array indicies from an enum (and move the axis names into an array as well).
There was a problem hiding this comment.
Fixed using string literals, also added cloning the default value. But let me know if you think using arrays is better. I just thought it might make the code slightly less readable.
sparhami
approved these changes
Oct 3, 2019
extensions/amp-orientation-observer/0.1/amp-orientation-observer.js
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors repetitive methods and fixes a minor bug