Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

📖clone documentation for sidebar v2 #24813

Merged
merged 5 commits into from Oct 4, 2019
Merged

📖clone documentation for sidebar v2 #24813

merged 5 commits into from Oct 4, 2019

Conversation

leafsy
Copy link
Contributor

@leafsy leafsy commented Sep 30, 2019

Fixes #24728

Clone the documentation for sidebar under v1.0 (with experimental added) and move existing markdown to v0.1:

amp-sidebar
├── _ 0.1
|   └── amp-sidebar.md
└── _ 1.0
    └── amp-sidebar.md (experimental)

@sebastianbenz would this fix the translation problem with doc importer?

sebastianbenz
sebastianbenz requested changes Oct 1, 2019
View reviewed changes
Copy link
Contributor

@sebastianbenz sebastianbenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Added to comments.

extensions/amp-sidebar/1.0/amp-sidebar.md Show resolved Hide resolved
extensions/amp-sidebar/1.0/amp-sidebar.md Show resolved Hide resolved
caroqliu
caroqliu approved these changes Oct 1, 2019
View reviewed changes
Copy link
Contributor

@caroqliu caroqliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice and thorough documentation! Just a few comments.

extensions/amp-sidebar/1.0/amp-sidebar.md Show resolved Hide resolved
extensions/amp-sidebar/1.0/amp-sidebar.md Outdated Show resolved Hide resolved
extensions/amp-sidebar/1.0/amp-sidebar.md Outdated Show resolved Hide resolved
extensions/amp-sidebar/1.0/amp-sidebar.md Outdated Show resolved Hide resolved
sebastianbenz
sebastianbenz approved these changes Oct 3, 2019
View reviewed changes
Copy link
Contributor

@sebastianbenz sebastianbenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks a lot!

@cathyxz cathyxz merged commit 76b0796 into ampproject:master Oct 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebastianbenz sebastianbenz sebastianbenz approved these changes

@caroqliu caroqliu caroqliu approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Clone documentation for amp-sidebar v2
5 participants
@leafsy @sebastianbenz @caroqliu @cathyxz @googlebot