Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

馃悰Adds true parallax to the amp-orientation-observer example #24823

Merged
merged 1 commit into from Oct 2, 2019
Merged

馃悰Adds true parallax to the amp-orientation-observer example #24823

merged 1 commit into from Oct 2, 2019

Conversation

wassgha
Copy link
Contributor

@wassgha wassgha commented Sep 30, 2019

Instead of the existing fake parallax (which acts only on a single axis) this example uses two parents, one for each axis, giving a more realistic parallax effect.

@wassgha wassgha requested review from sparhami and removed request for aghassemi September 30, 2019 20:29
@kristoferbaxter
Copy link
Contributor

Don't know why <amp-consent> would be impacted by this choice, might try running Percy again.

lannka
lannka approved these changes Oct 2, 2019
View reviewed changes
Copy link
Contributor

@lannka lannka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@wassgha wassgha merged commit fa2198a into ampproject:master Oct 2, 2019
@wassgha wassgha deleted the orientation-observer-demo-fix branch October 2, 2019 16:26
@wassgha wassgha mentioned this pull request Oct 2, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sparhami sparhami sparhami approved these changes

@lannka lannka lannka approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@wassgha @kristoferbaxter @sparhami @lannka @googlebot