gulp integration build command consistency #24830
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erwinmombay
approved these changes
Oct 1, 2019
rsimha
reviewed
Oct 4, 2019
| execOrDie(`gulp dist --fortesting --config ${argv.config}`); | ||
| } else { | ||
| execOrDie(`gulp build --config ${argv.config}`); | ||
| } |
There was a problem hiding this comment.
@powerivq gulp integration defaults to running against compiled code in the absence of --nobuild. This PR should have changed this block:
amphtml/build-system/tasks/runtime-test/helpers.js
Lines 161 to 165 in db49f43
There might be other places that need to be changed as well.
There was a problem hiding this comment.
Thanks. Defaulting to testing compiled code is great. I am seeing it actually using unminimized version of files though. I can talk a further look at why.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to run
gulp buildif we want to use unminimized bundle (amp.js vs v0.js). This PR fixes the problem thatgulp integrationby default does not build the right bundle it requires.