Story Ads: propagate visible attr to transformed body. #24831
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
powerivq
reviewed
Oct 1, 2019
| @@ -8,9 +8,9 @@ | |||
| <script async custom-element="amp-fit-text" src="https://cdn.ampproject.org/v0/amp-fit-text-0.1.js"></script> | |||
|
|
|||
| <meta name="amp-cta-type" content="INSTALL"> | |||
| <meta name="amp-cta-url" content="https://www.example.com"> | |||
| <meta name="amp-cta-url" content="https://www.amp.dev"> | |||
| <meta name="amp4ads-vars-attribution-icon" content="https://tpc.googlesyndication.com/pagead/images/adchoices/icon.png"> | |||
There was a problem hiding this comment.
Maybe we should substitute it with the icon that is local: /test/fixtures/e2e/amphtml-ads/resource/icon.png
powerivq
approved these changes
Oct 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some ad network partners will transform a creative after upload, including moving content that was previously in the
<body>into a separate<div>.This is a temporary solution until we have full ad network support or finalize a proper API, see #24829
Also introduces an e2e test with a transformed dv3 creative and removes some dv3 specific html from the base e2e test.