AMP4Email: Disallow "latest" extension scripts #24854
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @ampproject/wg-caching, these files were changed:
|
|
@choumx do we need to follow this deprecation path or does this fall outside of that policy? |
honeybadgerdontcare
approved these changes
Oct 2, 2019
There was a problem hiding this comment.
We should also update validator_test.js as well.
Otherwise, lgtm
|
Thanks for the quick review. We're mostly following those guidelines (filed I2D, announced on mailing list and Slack) though the policy itself can be tailored to fit email better. Will merge once we're in a good state. |
|
We used to check to make sure that there were at least 2 versions of every extension. It makes sense to remove this check and not just for Email and amp-carousel. There should be at least one version, not greater than one. |
honeybadgerdontcare
added a commit
that referenced
this pull request
Oct 16, 2019
Merged
honeybadgerdontcare
added a commit
that referenced
this pull request
Oct 16, 2019
joshuarrrr
pushed a commit
to Parsely/amphtml
that referenced
this pull request
Oct 22, 2019
* cl/274603953 Revision bump for ampproject#24854 * cl/274639638 Revision bump for ampproject#24909
This was referenced Oct 24, 2019
micajuine-ho
pushed a commit
to micajuine-ho/amphtml
that referenced
this pull request
Dec 27, 2019
* cl/274603953 Revision bump for ampproject#24854 * cl/274639638 Revision bump for ampproject#24909
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #24618.
/to @honeybadgerdontcare