Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AdGlare Ad Server: Added a cache buster to the URL. #24877

Merged
merged 4 commits into from Oct 4, 2019

Conversation

adglare
Copy link
Contributor

@adglare adglare commented Oct 3, 2019

No description provided.

@adglare
Copy link
Contributor Author

adglare commented Oct 3, 2019

Hi @lannka and @calebcordry

I've updated the URL to include a cache buster. Thanks for committing the change!

@adglare
Copy link
Contributor Author

adglare commented Oct 4, 2019

Also, could you please let me know how AdGlare can be added to this page?

https://amp.dev/support/faq/platform-and-vendor-partners/

Thanks again for your help - appreciated!

Copy link
Member

@calebcordry calebcordry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adglare Thanks for maintaining this extension! LGTM.

@calebcordry
Copy link
Member

As far as adding adGlare to amp.dev -- you should be able to make a PR to this file https://github.com/ampproject/amp.dev/blob/da0fbee9d4387a10d72703665ff506e3e812150f/pages/shared/data/faq.yaml#L73

Feel free to ping me on the PR and I will add a maintainer of that site to review.

Also it seems like a weird bundle-size flake on this PR. Could you rebase? That should reset the check. Thanks!

...as I'm not sure how to rebase.
@adglare
Copy link
Contributor Author

adglare commented Oct 4, 2019

Hi @calebcordry

I've changed a word to reset the checks. Hope the bundle size check will not timeout this time. I've also pinged you on ampproject/amp.dev#3070 as indicated. Thanks for your time!

@calebcordry calebcordry merged commit 4e49a64 into ampproject:master Oct 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants