♿ Expand tap target size for page attachment close button #24887
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @newmuis, these files were changed:
|
jackbsteinberg
changed the title
gmajoulet
approved these changes
Oct 3, 2019
jackbsteinberg
force-pushed
the
attachment-tap-target
branch
from
6577630
to
3418be0
Compare
newmuis
approved these changes
Oct 3, 2019
newmuis
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expanded the tap target size for the page attachment close button by switching the margin into padding and setting the background-origin to
content-boxto keep the X image in the center.Resolves #24808