Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃摉 Remove confusing emoji codes from PR template #24892

Merged
merged 1 commit into from Oct 3, 2019
Merged

馃摉 Remove confusing emoji codes from PR template #24892

merged 1 commit into from Oct 3, 2019

Conversation

rsimha
Copy link
Contributor

@rsimha rsimha commented Oct 3, 2019

The PR template instructs developers to include emoji in their PR descriptions. Copying the emoji works, but copying the emoji code does not.

This PR removes the emoji code from the template so people don't copy it by mistake.

Copy link
Contributor

@newmuis newmuis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

馃憤 馃帀 馃帄 馃檶 馃檹

@rsimha rsimha merged commit adbe236 into ampproject:master Oct 3, 2019
@rsimha rsimha deleted the 2019-10-03-PrEmojiCode branch October 3, 2019 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants