🏗 Convert all OWNERS.yaml files to JSON5 format #24934
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rsimha
approved these changes
Oct 7, 2019
|
For posterity: This PR will be submitted with a failing owners check because it modifies owners files without extensions, but I have ownership of all owners files and it's a no-op change that does not actually change any rules. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created with this conversion script
To generate this PR, each OWNERS.yaml file was parsed and then re-written in JSON5 format. The original YAML files were deleted. The accuracy of this transition was verified by parsing the new vs old OWNERS file sets and verifying that the output ownership tree was identical.
This should be submitted as soon as possible to reduce risk of merge conflicts. It's better to do it like this (rather than leave both YAML and JSON versions in place) so there is less risk of contributors editing the deprecated YAML files. Note that the parser will still support YAML (ie. it won't break anything if someone checks in an old YAML file), and I'm still being notified of all OWNERS/OWNERS.yaml changes, so I can catch anyone who tries 👮♂️
The new owners files point to the updated example OWNERS file.
Related to ampproject/amp-github-apps#442