Performance measurements adjustments. #2494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
cramforce
commented
Mar 8, 2016
cramforce
commented
- Flush more often to make sure we don't miss important measurements.
- Shift framerate values, so that smaller values are better, because our reporting tool thinks these are ms.
| @@ -127,9 +127,12 @@ export class Framerate { | |||
| const duration = now - this.collectStartTime_; | |||
| const framerate = 1000 / (duration / this.frameCount_); | |||
| const performance = performanceFor(this.win); | |||
| performance.tickDelta('fps', framerate); | |||
| // We want good values to be low and CSI hates negative values, so we | |||
| // shift everything by 60 and then | |||
There was a problem hiding this comment.
shift everything by 60 and then...?
|
@cramforce LGTM |
- Flush more often to make sure we don't miss important measurements. - Shift framerate values, so that smaller values are better, because our reporting tool thinks these are ms.
Wouldn't it be better to convert these to ms then? What we have now will cap |
|
@jridgewell I've thought about it, but the real answer there is to probably rethink this entire metric. The current approach is measuring too much time where nothing happens to make the averages meaningful in any way. |
cramforce
added a commit
that referenced
this pull request
Mar 9, 2016
Performance measurements adjustments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.