Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃彈 Lint OWNERS files with gulp lint #24943

Merged
merged 1 commit into from Oct 7, 2019
Merged

馃彈 Lint OWNERS files with gulp lint #24943

merged 1 commit into from Oct 7, 2019

Conversation

rsimha
Copy link
Contributor

@rsimha rsimha commented Oct 7, 2019

This PR makes it so that gulp lint, gulp lint --local_changes, and gulp lint --files=<glob> are all capable of linting OWNERS files.

Example usage:

$ gulp lint --files=build-system/**/OWNERS
[16:47:00] Using gulpfile ~/src/amphtml/gulpfile.js
[16:47:00] Starting 'lint'...
[16:47:00] All packages in node_modules are up to date.
[16:47:00] INFO: Running lint on the following files:
[16:47:00] build-system/global-configs/OWNERS
[16:47:00] build-system/OWNERS
[16:47:01] SUCCESS: No linter warnings or errors.
[16:47:01] Finished 'lint' after 816 ms
$ gulp lint --local_changes
[16:47:45] Using gulpfile ~/src/amphtml/gulpfile.js
[16:47:45] Starting 'lint'...
[16:47:45] All packages in node_modules are up to date.
[16:47:45] INFO: Running lint on the following files:
[16:47:45] build-system/OWNERS
[16:47:45] build-system/tasks/lint.js
[16:47:46] SUCCESS: No linter warnings or errors.
[16:47:46] Finished 'lint' after 1 s

Follow up to #24938

@rsimha rsimha self-assigned this Oct 7, 2019
@rsimha rsimha merged commit e430da6 into ampproject:master Oct 7, 2019
@rsimha rsimha deleted the 2019-10-07-LintOwnersFiles branch October 7, 2019 21:24
@estherkim
Copy link
Collaborator

Dang 2 min too late.

Copy link
Contributor Author

@rsimha rsimha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dang 2 min too late.

Good catch, but this was an intentional change improved by your feedback :)

build-system/tasks/lint.js Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants