Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃摉 Formats amp-story attributes section as a table. #24962

Merged
merged 1 commit into from Oct 8, 2019

Conversation

cpauwels
Copy link
Contributor

@cpauwels cpauwels commented Oct 8, 2019

  • Changes the format of the amp-story attributes section to a table
  • Updates the internal anchors referring to the attributes

@amp-owners-bot amp-owners-bot bot requested a review from newmuis October 8, 2019 19:02
@amp-owners-bot
Copy link

amp-owners-bot bot commented Oct 8, 2019

Hey @gmajoulet, these files were changed:

  • extensions/amp-story/amp-story.md

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

馃摑 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

鈩癸笍 Googlers: Go here for more info.

@cpauwels
Copy link
Contributor Author

cpauwels commented Oct 8, 2019

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

鈩癸笍 Googlers: Go here for more info.

@googlebot googlebot added cla: yes and removed cla: no labels Oct 8, 2019
@cpauwels
Copy link
Contributor Author

cpauwels commented Oct 8, 2019

Closes #23648, cc @CrystalOnScript

Copy link
Contributor

@gmajoulet gmajoulet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but let's wait for @CrystalOnScript approval too :)

Copy link
Contributor

@CrystalOnScript CrystalOnScript left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful! Thank you!

@CrystalOnScript
Copy link
Contributor

Resolves issue #23648

Copy link
Contributor

@newmuis newmuis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woohoo 馃帀

Thanks @cpauwels, and nice catch for the broken links!

@gmajoulet gmajoulet merged commit 61432c2 into ampproject:master Oct 8, 2019
@estherkim
Copy link
Collaborator

estherkim commented Feb 10, 2020

Closes #23648

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants