Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📖 Make PR template text invisible even when it is inadvertently included in a PR description #24966

Merged
merged 2 commits into from Oct 9, 2019
Merged

📖 Make PR template text invisible even when it is inadvertently included in a PR description #24966

merged 2 commits into from Oct 9, 2019

Conversation

rsimha
Copy link
Contributor

@rsimha rsimha commented Oct 8, 2019

This PR hides the PR template boilerplate even if it is inadvertently included in a PR description. Note that the instructions will still be visible when developers are writing their PR descriptions, because the github editor displays raw markup.

@mrjoro @CrystalOnScript WDYT?

For example:

Screen Shot 2019-10-08 at 4 23 41 PM

@rsimha rsimha requested a review from jridgewell October 8, 2019 21:12
Copy link
Contributor

@CrystalOnScript CrystalOnScript left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LOVE IT

@amp-owners-bot
Copy link

amp-owners-bot bot commented Oct 9, 2019

Hey @rcebulko, these files were changed:

  • .github/OWNERS

Copy link
Contributor

@rcebulko rcebulko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love this! Approving changes to .github/OWNERS

@rsimha rsimha merged commit 1733bad into ampproject:master Oct 9, 2019
@rsimha rsimha deleted the 2019-10-08-HidePrTemplateText branch October 9, 2019 17:16
micajuine-ho pushed a commit to micajuine-ho/amphtml that referenced this pull request Dec 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants