Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🏗 A few minor OWNERS fixes #24971

Merged
merged 5 commits into from
Oct 9, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 3 additions & 0 deletions .eslintignore
Original file line number Diff line number Diff line change
Expand Up @@ -18,3 +18,6 @@ extensions/amp-a4a/0.1/test/testdata/**
testing/local-amp-chrome-extension/**
third_party/**
validator/**

# Lint all OWNERS files
!**/OWNERS
5 changes: 1 addition & 4 deletions .prettierrc
Original file line number Diff line number Diff line change
Expand Up @@ -3,15 +3,12 @@
"singleQuote": true,
"trailingComma": "es5",
"quoteProps": "preserve",

"overrides": [{
"files": "OWNERS",
"options": {
"parser": "json5",
"bracketSpacing": true,
"quoteProps": "as-needed",
"tabWidth": 2,
"trailingComma": "none",
"trailingComma": "none"
}
}]
}
34 changes: 5 additions & 29 deletions OWNERS
Original file line number Diff line number Diff line change
Expand Up @@ -5,41 +5,23 @@
rules: [
{
owners: [
{
name: 'cramforce',
requestReviews: false
},
{
name: 'dvoytenko',
requestReviews: false
},
{
name: 'jridgewell',
requestReviews: false
}
{ name: 'cramforce', requestReviews: false },
{ name: 'dvoytenko', requestReviews: false },
{ name: 'jridgewell', requestReviews: false }
]
},

{
pattern: '**/validator-*.{protoascii,html,out}',
owners: [
{
name: 'ampproject/wg-caching',
notify: true
}
]
owners: [{ name: 'ampproject/wg-caching', notify: true }]
},

{
pattern: '*.md',
owners: [{ name: 'ampproject/wg-outreach' }]
},

{
pattern: '{.*,babel.config.js,gulpfile.js}',
owners: [{ name: 'ampproject/wg-infra' }]
},

{
pattern: '{package.json,yarn.lock}',
owners: [
Expand All @@ -48,7 +30,6 @@
{ name: 'ampproject/wg-performance' }
]
},

{
// The below rule will be here only temporarily during the transition
// period while many owners files are being updated as contributors and
Expand All @@ -64,12 +45,7 @@
// TODO(#24685): Remove this once most owners files have been updated
// and/or the Travis check is implemented.
pattern: '**/{OWNERS.yaml,OWNERS}',
owners: [
{
name: 'rcebulko',
notify: true
}
]
owners: [{ name: 'rcebulko', notify: true }]
}
]
}
7 changes: 3 additions & 4 deletions css/OWNERS
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,9 @@
rules: [
{
owners: [
{ name: 'aghassemi' },
{ name: 'camelburrito' },
{ name: 'kristoferbaxter' },
{ name: 'sparhami' }
{ name: 'ampproject/wg-ui-and-a11y' },
rsimha marked this conversation as resolved.
Show resolved Hide resolved
{ name: 'aghassemi', requestReviews: false },
{ name: 'camelburrito', requestReviews: false }
]
}
]
Expand Down
4 changes: 1 addition & 3 deletions examples/OWNERS
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,7 @@
{
rules: [
{
owners: [
{ name: '*' }
]
owners: [{ name: '*' }]
}
]
}
15 changes: 6 additions & 9 deletions extensions/OWNERS
Original file line number Diff line number Diff line change
Expand Up @@ -4,19 +4,16 @@
{
rules: [
{
owners: [{ name: 'aghassemi' }]
owners: [
{ name: 'ampproject/wg-ui-and-a11y' },
{ name: 'aghassemi', requestReviews: false }
]
},
{
pattern: '**/*-player.{js,md}',
owners: [
{
name: 'alanorozco',
notify: true
},
{
name: 'wassgha',
notify: true
}
{ name: 'alanorozco', notify: true },
{ name: 'wassgha', notify: true }
]
}
]
Expand Down
7 changes: 3 additions & 4 deletions tools/OWNERS
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,9 @@
rules: [
{
owners: [
{ name: 'aghassemi' },
{ name: 'choumx' },
{ name: 'erwinmombay' },
{ name: 'rsimha' }
{ name: 'ampproject/wg-infra' },
{ name: 'ampproject/runtime' },
{ name: 'ampproject/performance' }
]
}
]
Expand Down
4 changes: 1 addition & 3 deletions validator/OWNERS
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,7 @@
{
rules: [
{
owners: [
{ name: 'ampproject/wg-caching' }
]
owners: [{ name: 'ampproject/wg-caching' }]
}
]
}