Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better inabox console message when message.source is null #24977

Merged
merged 1 commit into from Oct 9, 2019
Merged

Better inabox console message when message.source is null #24977

merged 1 commit into from Oct 9, 2019

Conversation

lannka
Copy link
Contributor

@lannka lannka commented Oct 8, 2019

for #24873

@lannka lannka requested a review from powerivq October 8, 2019 22:05
@lannka lannka mentioned this pull request Oct 8, 2019
Closed
@lannka lannka merged commit 136b3f2 into ampproject:master Oct 9, 2019
@lannka lannka deleted the inabox-missing-message-source branch October 9, 2019 23:01
micajuine-ho pushed a commit to micajuine-ho/amphtml that referenced this pull request Dec 27, 2019
@lannka
Better console message when message.source is null (ampproject#24977)
1c3c58a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@powerivq powerivq powerivq approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lannka @powerivq @googlebot