Story branching navigation path fixes. #24979
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
newmuis
reviewed
Oct 9, 2019
newmuis
approved these changes
Oct 9, 2019
micajuine-ho
pushed a commit
to micajuine-ho/amphtml
that referenced
this pull request
Dec 27, 2019
* Story navigation path fixes. * Reviews.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing a few things about the story navigation path.
The
updateNavigationPathmethod used to decide of the target page: you'd callswitchTowith a page ID, but it would be overridden in some cases. This was causing different bugs with progress bar and history, as thetargetPagewas overridden but not thetargetPageId.Instead, the navigation path is now stored and globally accessible. Pages, when getting the previous page id, look up in the navigation path. This way
switchToactually navigates to the page you passed as a parameter, making its behavior easier to predict and removing the previously mentioned bugs.updateNavigationPathno longer decides of the target page, but only updates the store + history.