Remove the branching share page checkbox. #24980
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
newmuis
approved these changes
Oct 9, 2019
…ore pushing. I will run gulp pr-check before pushing. I will run gulp pr-check before pushing. I will run gulp pr-check before pushing.
|
Filed #24992 |
micajuine-ho
pushed a commit
to micajuine-ho/amphtml
that referenced
this pull request
Dec 27, 2019
* Remove the branching share page checkbox. * I will run gulp pr-check before pushing. I will run gulp pr-check before pushing. I will run gulp pr-check before pushing. I will run gulp pr-check before pushing. I will run gulp pr-check before pushing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing this checkbox for desktop/mobile parity, as native sharing where we don't control the shared URL (unless we hack the
location.href?) is now supported on both iOS and Android.I'm open to discussing keeping it, but this would require UX work to get the wording + design right.