Media Pool: generate HTMLSourceElement from the src attribute. #25003
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cached videos don't fallback to the origin video when configured as attributes of
<amp-video>
.The media pool will remove the
src
attribute before theamp-video.layoutCallback
runs, preventing it from propagating the cached src as a source of the new<video>
element.Solution is to transform the
src
attribute as aHTMLSourceElement
, that will later be picked up byamp-video.layoutCallback
.This fixes stories like this one (see page 2).