🐛Consider *.gmail.com trusted viewer domains

[zhangsu]

Gmail mobile clients use *.gmail.com as the base URL for the WebView
that embeds the AMP HTML iframe.

/to @choumx

[cramforce]

@rsimha Could we move this into the Google AMP Cache config instead of making it part of the core repo? This and all the other trusted viewers owned by Google.

[rsimha]

@rsimha Could we move this into the Google AMP Cache config instead of making it part of the core repo? This and all the other trusted viewers owned by Google.

@cramforce Should be possible. Would something similar to caches.json be a worthwhile place to add this to? Or are you thinking of a file outside the ampproject/amphtml repo?

@alabiaga, since you added this field, could you shed some light on how it is currently used, and how we might use it if this were no longer checked in to the core repo?

[dreamofabear]

could you shed some light on how it is currently used, and how we might use it if this were no longer checked in to the core repo?

It's currently used to enable features that should only run on certain embedding environments (iframe hosts).

I think the suggestion is to just move this into a transform in the Google AMP Cache. It would avoid other caches from having Google-specific values baked into the default for this field.

[alabiaga]

@rsimha Will mentioned its purpose. I added the field but it originally existed and was just moved to a different file. As seen here: https://github.com/ampproject/amphtml/pull/23039/files#diff-4355db0ba8ae714ce669b977af9c8dfd

Also apologies..as I was supposed to look into the task of moving this into an amp cache config but I was already in my new role and didn't get around to it.

[cramforce]

yeah, I just meant that these Google defaults should be removed from the OSS repo and instead added by Google.

…

On Mon, Oct 14, 2019 at 8:16 PM William Chou ***@***.***> wrote: Merged #25027 <#25027> into master. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#25027?email_source=notifications&email_token=AAAV4T6AGXY4EOXWOPPKNULQOSZPDA5CNFSM4JAH2X22YY3PNVWWK3TUL52HS4DFWZEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZGOUGOEQ4Y#event-2711373939>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAV4T2RXNO3TVDCSYZRADLQOSZPDANCNFSM4JAH2X2Q> .