✨Add "conative" ad network support to amp-ad #25038
Conversation
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
|
fyi: i'm still waiting for the CLA |
| @@ -351,6 +351,10 @@ const adConfig = jsonConfiguration({ | |||
| prefetch: 'https://static.clmbtech.com/ad/commons/js/colombia-amp.js', | |||
| }, | |||
|
|
|||
| 'conative': { | |||
| renderStartImplemented: true, | |||
There was a problem hiding this comment.
verified renderStart is being called. 👍
ads/conative.js
Outdated
| * @param {!Object} data | ||
| */ | ||
| export function conative(global, data) { | ||
| validateData(data, ['domain', 'adslot', 'height']); |
There was a problem hiding this comment.
You are able to add optional params as a third arg to this function. Would you like to include preview here?
|
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
ads/conative.md
Outdated
| <amp-ad | ||
| height="250" | ||
| width="300" | ||
| type="conative" |
There was a problem hiding this comment.
nit: can you indent all these to the same level?
There was a problem hiding this comment.
sorry, my bad! done!
|
Thanks for the contribution! |
* added 'conative' ad network * added 'conative' ad network * added 'conative' ad network * passed 'preview' as optional parameter to validateData() * Revert "passed 'preview' as optional parameter to validateData()" This reverts commit 1e8160a. * passed 'preview' as optional parameter to validateData() * fixed linter error * fixed line intendation
* added 'conative' ad network * added 'conative' ad network * added 'conative' ad network * passed 'preview' as optional parameter to validateData() * Revert "passed 'preview' as optional parameter to validateData()" This reverts commit 1e8160a. * passed 'preview' as optional parameter to validateData() * fixed linter error * fixed line intendation
This adds "conative" ad network support to amp-ad.