🏗 Report and store the bundle size of alternate runtime and extension files #25042
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rcebulko
reviewed
Oct 14, 2019
| @@ -208,7 +213,7 @@ function getLocalBundleSize() { | |||
| cyan(shortSha(gitCommitHash())) + '.' | |||
| ); | |||
| } | |||
| getBrotliBundleSize(); | |||
| getBrotliBundleSizes(); | |||
There was a problem hiding this comment.
What's the point of this call? Should this function be returning something? JSDoc would help, but also not clear if there's any point to this function call
There was a problem hiding this comment.
getBrotliBundleSizes prints its own logs. @rsimha added the getLocalBundleSize() method originally, I'm just updating here
There was a problem hiding this comment.
So the point of this is just to log stuff?
There was a problem hiding this comment.
Yes, it's a debugging thing
rcebulko
approved these changes
Oct 14, 2019
| @@ -208,7 +213,7 @@ function getLocalBundleSize() { | |||
| cyan(shortSha(gitCommitHash())) + '.' | |||
| ); | |||
| } | |||
| getBrotliBundleSize(); | |||
| getBrotliBundleSizes(); | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Releated to ampproject/amp-github-apps#271