Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Update INFOnline analytics vendor configuration #25053

Merged

Conversation

infonline
Copy link
Contributor

  • Add new request type event to allow event based analytics requests
  • Add type to query parameters for pageview and event requests to allow a different processing

Resolves #23276

* add new request type event to allow event based analytics requests
* add type to query parameters for pageview and event requests
@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@infonline
Copy link
Contributor Author

@googlebot I fixed it.

@googlebot
Copy link

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@infonline
Copy link
Contributor Author

@googlebot I consent.

1 similar comment
@io-joswald
Copy link

@googlebot I consent.

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

Copy link
Member

@calebcordry calebcordry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the continued maintenance of this integration!

@calebcordry calebcordry merged commit 6efd1ec into ampproject:master Oct 15, 2019
joshuarrrr pushed a commit to Parsely/amphtml that referenced this pull request Oct 22, 2019
* add new request type event to allow event based analytics requests
* add type to query parameters for pageview and event requests
micajuine-ho pushed a commit to micajuine-ho/amphtml that referenced this pull request Dec 27, 2019
* add new request type event to allow event based analytics requests
* add type to query parameters for pageview and event requests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

amp-analytics: Triggers in Infonline html vs. image request
4 participants