Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🏗✨ Check non-JS files for formatting errors using prettier during local and Travis PR checks #25057

Merged
merged 10 commits into from Oct 16, 2019
Merged

🏗✨ Check non-JS files for formatting errors using prettier during local and Travis PR checks #25057

merged 10 commits into from Oct 16, 2019
+381 −70

Commits on Oct 16, 2019

  1. Add a gulp task to check OWNERS files for formatting errors

    @rsimha
    rsimha committed Oct 16, 2019
    Configuration menu
    Copy the full SHA
    fc52fb9 View commit details
    Browse the repository at this point in the history

  2. Check OWNERS files during local and Travis PR checks

    @rsimha
    rsimha committed Oct 16, 2019
    Configuration menu
    Copy the full SHA
    244dca9 View commit details
    Browse the repository at this point in the history

  3. Fix tYpo

    @rsimha
    rsimha committed Oct 16, 2019
    Configuration menu
    Copy the full SHA
    b1c80bc View commit details
    Browse the repository at this point in the history

  4. Remove unnecessary prettier command line args

    @rsimha
    rsimha committed Oct 16, 2019
    Configuration menu
    Copy the full SHA
    129dc7d View commit details
    Browse the repository at this point in the history

  5. Rename checkFile to checkFormatting and add a TODO for checkCorrectness

    @rsimha
    rsimha committed Oct 16, 2019
    Configuration menu
    Copy the full SHA
    5f35930 View commit details
    Browse the repository at this point in the history

  6. Refactor formatting and correctness checks into separate gulp tasks

    @rsimha
    rsimha committed Oct 16, 2019
    Configuration menu
    Copy the full SHA
    2abc8fd View commit details
    Browse the repository at this point in the history

  7. Review feedback

    @rsimha
    rsimha committed Oct 16, 2019
    Configuration menu
    Copy the full SHA
    bcee3ec View commit details
    Browse the repository at this point in the history

  8. Undo asynchronousness of checkFile in check-owners.js

    @rsimha
    rsimha committed Oct 16, 2019
    Configuration menu
    Copy the full SHA
    532691a View commit details
    Browse the repository at this point in the history

  9. Include caches.json in gulp prettify check

    @rsimha
    rsimha committed Oct 16, 2019
    Configuration menu
    Copy the full SHA
    6eb5998 View commit details
    Browse the repository at this point in the history

  10. Fix formatting in extensions/amp-mega-menu/OWNERS

    @rsimha
    rsimha committed Oct 16, 2019
    Configuration menu
    Copy the full SHA
    05cd7cf View commit details
    Browse the repository at this point in the history