New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✅ Deflakes SwG E2E Test #25065
✅ Deflakes SwG E2E Test #25065
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but need @chenshay's review.
@ChrisAntaki Thanks for fixing our tests! Looks like it failed on |
It doesn't repro often locally, but when it does here's what I see:
|
Here are the complete logs from a failed run. Interestingly, the amp-subscriptions plugin does seem to kick off a request (which is expected to fail) later, so it does load eventually. Perhaps there's a race condition with the loading of extensions?
|
* Adds failinge expectation * Fixes expectation * Verify size of btn * Fixes comment
* Adds failinge expectation * Fixes expectation * Verify size of btn * Fixes comment
This PR deflakes the SwG E2E test by waiting for the SwG button to render before triggering a click.