Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

馃彈 Replace globs-to-files with globby #25097

Merged
merged 2 commits into from Oct 17, 2019
Merged

馃彈 Replace globs-to-files with globby #25097

merged 2 commits into from Oct 17, 2019

Conversation

rsimha
Copy link
Contributor

@rsimha rsimha commented Oct 17, 2019 •
edited

This PR replaces globs-to-files with globby across build-system/ (and removes the now unnecessary step of converting the resulting filenames to relative paths).

  • globs-to-files:
    • ~1000 weekly downloads
    • Hasn't been updated in 4 years
    • Cannot handle negative glob patterns
  • globby:
    • ~16 million weekly downloads
    • Actively maintained
    • Significantly faster than other packages
    • Can handle negative glob patterns

Addresses #25093 (comment)

@rsimha rsimha self-assigned this Oct 17, 2019
@amp-owners-bot
Copy link

Hey @estherkim, these files were changed:

  • build-system/tasks/runtime-test/helpers-unit.js

@rsimha rsimha mentioned this pull request Oct 17, 2019
Merged
@rsimha rsimha requested a review from estherkim October 17, 2019 18:21
kristoferbaxter
kristoferbaxter approved these changes Oct 17, 2019
View reviewed changes
Copy link
Contributor

@kristoferbaxter kristoferbaxter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice simplification here.

@rsimha rsimha merged commit f3518c0 into ampproject:master Oct 17, 2019
@rsimha rsimha deleted the 2019-10-17-Globby branch October 17, 2019 20:15
joshuarrrr pushed a commit to Parsely/amphtml that referenced this pull request Oct 22, 2019
@rsimha @joshuarrrr
馃彈 Replace globs-to-files with globby (ampproject#25097)
100c785
micajuine-ho pushed a commit to micajuine-ho/amphtml that referenced this pull request Dec 27, 2019
@rsimha
馃彈 Replace globs-to-files with globby (ampproject#25097)
d72b7a1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kristoferbaxter kristoferbaxter kristoferbaxter approved these changes

@danielrozenberg danielrozenberg danielrozenberg approved these changes

@estherkim estherkim estherkim approved these changes

Assignees

@rsimha rsimha

Labels
cla: yes WG: infra
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@rsimha @kristoferbaxter @danielrozenberg @estherkim @googlebot