amp-lightbox: Propagate trust from action->event #25112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
|
@alanorozco Friendly ping. :) |
alanorozco
approved these changes
Oct 23, 2019
| @@ -181,8 +181,8 @@ class AmpLightbox extends AMP.BaseElement { | |||
| this.action_ = Services.actionServiceForDoc(this.element); | |||
| this.maybeSetTransparentBody_(); | |||
|
|
|||
| this.registerDefaultAction(unused => this.open_(), 'open'); | |||
| this.registerAction('close', this.close.bind(this)); | |||
| this.registerDefaultAction(i => this.open_(i.trust), 'open'); | |||
There was a problem hiding this comment.
micronit: destructure?
({trust}) => this.open_(trust)There was a problem hiding this comment.
IMO dot syntax is more readable here, especially for a single property. :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partial for #24894.
Ensure that the same trust level open/close/toggle action is called with is passed to the resulting open/close event to prevent trust escalation. Similar to #24425.
/to @alanorozco