Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix syntax for spec/email/OWNERS #25114

Merged
merged 2 commits into from Oct 17, 2019
Merged

Fix syntax for spec/email/OWNERS #25114

merged 2 commits into from Oct 17, 2019

Conversation

alanorozco
Copy link
Member

No description provided.

@rcebulko
Copy link
Contributor

Looks like this was just a syntax issue introduced in #25062 ; fortunately, gulp prettify added in recent PRs should prevent any invalid JSON from being submitted. @rsimha can you confirm that pr-check will catch syntax errors now, until we get the full parsing validation API in place?

@honeybadgerdontcare honeybadgerdontcare merged commit da3755d into master Oct 17, 2019
@honeybadgerdontcare honeybadgerdontcare mentioned this pull request Oct 17, 2019
Closed
@rsimha
Copy link
Contributor

rsimha commented Oct 18, 2019

can you confirm that pr-check will catch syntax errors now, until we get the full parsing validation API in place?

Yes, future errors will be caught by gulp prettify during CI.

Alternatives during local dev:

  • Run gulp prettify --local_changes --fix before uploading commits to GitHub
  • Use the upcoming auto-fix-on-save workflow for VS Code (it works beautifully for OWNERS files)

jeffjose pushed a commit to jeffjose/amphtml that referenced this pull request Oct 19, 2019
@alanorozco @jeffjose
Fix syntax for spec/email/OWNERS (ampproject#25114)
ffa2970 
* Fix syntax for spec/email/OWNERS

* lint
joshuarrrr pushed a commit to Parsely/amphtml that referenced this pull request Oct 22, 2019
@alanorozco @joshuarrrr
Fix syntax for spec/email/OWNERS (ampproject#25114)
1d5ab4e 
* Fix syntax for spec/email/OWNERS

* lint
micajuine-ho pushed a commit to micajuine-ho/amphtml that referenced this pull request Dec 27, 2019
@alanorozco
Fix syntax for spec/email/OWNERS (ampproject#25114)
4c6e819 
* Fix syntax for spec/email/OWNERS

* lint
@rsimha rsimha deleted the alanorozco-spec-email-owners branch February 13, 2020 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rcebulko rcebulko rcebulko approved these changes

@dreamofabear dreamofabear dreamofabear approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@alanorozco @rcebulko @rsimha @dreamofabear @honeybadgerdontcare @googlebot