Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃摝 Update dependency amphtml-validator to v1.0.26 #25146

Merged

Conversation

renovate-bot
Copy link
Contributor

@renovate-bot renovate-bot commented Oct 18, 2019

This PR contains the following updates:

Package Type Update Change
amphtml-validator devDependencies patch 1.0.23 -> 1.0.26

Renovate configuration

馃搮 Schedule: At any time (no schedule defined).

馃殾 Automerge: Disabled by config. Please merge this manually once you are satisfied.

鈾伙笍 Rebasing: Whenever PR becomes conflicted, or if you modify the PR title to begin with "rebase!".

馃敃 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot. View repository job log here.

@renovate-bot renovate-bot changed the title 馃摝 Update dependency amphtml-validator to v1.0.24 馃摝 Update dependency amphtml-validator to v1.0.25 Oct 18, 2019
@rsimha
Copy link
Contributor

rsimha commented Oct 18, 2019

This didn't update yarn.lock. @honeybadgerdontcare Any idea why?

@honeybadgerdontcare
Copy link
Contributor

I'm not sure why. Though we are just now revving it to 1.0.26 so we could just wait for that to be merged.

@renovate-bot renovate-bot changed the title 馃摝 Update dependency amphtml-validator to v1.0.25 馃摝 Update dependency amphtml-validator to v1.0.26 Oct 18, 2019
@rsimha
Copy link
Contributor

rsimha commented Oct 18, 2019

Passing check with the latest version: https://travis-ci.org/ampproject/amphtml/jobs/599895079#L366

Looks like #25153 did the trick!

@rsimha rsimha merged commit f67728e into ampproject:master Oct 18, 2019
@renovate-bot renovate-bot deleted the renovate/amphtml-validator-1.x branch October 18, 2019 23:49
jeffjose pushed a commit to jeffjose/amphtml that referenced this pull request Oct 19, 2019
joshuarrrr pushed a commit to Parsely/amphtml that referenced this pull request Oct 22, 2019
micajuine-ho pushed a commit to micajuine-ho/amphtml that referenced this pull request Dec 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants