Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🏗 Pre-build JS files and extensions loaded by core runtime during gulp startup #25155

Merged
merged 3 commits into from Oct 20, 2019
Merged

🏗 Pre-build JS files and extensions loaded by core runtime during gulp startup #25155

merged 3 commits into from Oct 20, 2019

Conversation

rsimha
Copy link
Contributor

@rsimha rsimha commented Oct 19, 2019

Background:

The default gulp task pre-builds the core runtime, and lazy builds all other JS files and extensions. This results in 404 errors for files that are sometimes loaded by the core runtime without a separate server request (#25024, #24226).

PR highlights:

  • Pre-builds ww.js during default gulp startup
  • Pre-builds amp-loader and amp-auto-lightbox during default gulp startup
  • Waits for pre-build tasks to complete before ending default gulp task
  • Fixes logging to indicate which extensions are being pre-built
  • Server startup still happens before pre-build tasks are executed

Fixes #25024
Fixes #24226

build-system/tasks/serve.js Show resolved Hide resolved
@rsimha rsimha merged commit 419bebb into ampproject:master Oct 20, 2019
@rsimha rsimha deleted the 2019-10-19-FixLazyBuild branch October 20, 2019 04:01
joshuarrrr pushed a commit to Parsely/amphtml that referenced this pull request Oct 22, 2019
micajuine-ho pushed a commit to micajuine-ho/amphtml that referenced this pull request Dec 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants