Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OWNERS for extension generator task #25165

Merged
merged 3 commits into from Oct 24, 2019
Merged

Conversation

alanorozco
Copy link
Member

No description provided.

@@ -0,0 +1,14 @@
// For an explanation of the OWNERS rules and syntax, see:
// https://github.com/ampproject/amp-github-apps/blob/master/owners/OWNERS.example
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For posterity, and since I'm not intimately familiar with this directory, can you explain why each of these groups owns it?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added comments. Removed infra since it's redundant per parent directory.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it make sense to disable review requests here? It seems reasonable to include these groups in the reviewer pool during reviewer selection

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If Outreach maintains it, I think they should be looped in on reviews. Note that on a PR where someone has already been added to cover this file, no one new will be added for it. So, I think we want to enable review requests for at least one of these teams

@alanorozco alanorozco merged commit 7f69eac into ampproject:master Oct 24, 2019
@alanorozco alanorozco deleted the extowners branch October 24, 2019 00:54
micajuine-ho pushed a commit to micajuine-ho/amphtml that referenced this pull request Dec 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants