New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OWNERS for extension generator task #25165
Conversation
@@ -0,0 +1,14 @@ | |||
// For an explanation of the OWNERS rules and syntax, see: | |||
// https://github.com/ampproject/amp-github-apps/blob/master/owners/OWNERS.example |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For posterity, and since I'm not intimately familiar with this directory, can you explain why each of these groups owns it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added comments. Removed infra
since it's redundant per parent directory.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does it make sense to disable review requests here? It seems reasonable to include these groups in the reviewer pool during reviewer selection
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If Outreach maintains it, I think they should be looped in on reviews. Note that on a PR where someone has already been added to cover this file, no one new will be added for it. So, I think we want to enable review requests for at least one of these teams
No description provided.