Separate experiments object block from experiment.js code #25169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @rcebulko, these files were changed:
|
rcebulko
approved these changes
Oct 22, 2019
rsimha
reviewed
Oct 22, 2019
joshuarrrr
pushed a commit
to Parsely/amphtml
that referenced
this pull request
Oct 22, 2019
…#25169) * Separate experiments object block from experiment.js code * Add @fileoverview * Change reviewers to working-groups * Move OWNERS file from tools to tools/experiments
micajuine-ho
pushed a commit
to micajuine-ho/amphtml
that referenced
this pull request
Dec 27, 2019
…#25169) * Separate experiments object block from experiment.js code * Add @fileoverview * Change reviewers to working-groups * Move OWNERS file from tools to tools/experiments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We add a new experiment every time we add a new component and remove it post-launch. I wonder if it makes sense to separate the config block for adding/removing experiments from the code that actually runs the experiments. That way we can have more expansive ownership permissions of the experiments config, while locking down permissions to merge into the experimentation code itself.