Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redefine ampdoc-fie experiment as a branched experiment #25174

Merged
merged 4 commits into from Oct 24, 2019
Merged

Redefine ampdoc-fie experiment as a branched experiment #25174

merged 4 commits into from Oct 24, 2019

Conversation

dvoytenko
Copy link
Contributor

Partial for #22734.

jridgewell
jridgewell approved these changes Oct 22, 2019
View reviewed changes
Copy link
Contributor

@jridgewell jridgewell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a as a parameter to the FIE creation code? That way the caller (adsense or doubleclick) could be the ones paying for the bytes, not v0.

@dvoytenko
Copy link
Contributor Author

Is there a as a parameter to the FIE creation code? That way the caller (adsense or doubleclick) could be the ones paying for the bytes, not v0.

Unfortunately there's no way to do this per-fie. This mode changes some fundamentals of service resolution and thus applied on the runtime level.

@dvoytenko dvoytenko merged commit 54087c3 into ampproject:master Oct 24, 2019
@dvoytenko dvoytenko deleted the ampdoc-fie6 branch October 24, 2019 16:47
micajuine-ho pushed a commit to micajuine-ho/amphtml that referenced this pull request Dec 27, 2019
Redefine ampdoc-fie experiment as a branched experiment (ampproject#2…
5ac83cf 
…5174)

* Redefine ampdoc-fie experiment as a branched experiment

* notes

* switch control and experiment ids

* fix tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jridgewell jridgewell jridgewell approved these changes

@powerivq powerivq Awaiting requested review from powerivq

@lannka lannka Awaiting requested review from lannka

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dvoytenko @jridgewell @googlebot