Navigation: Fix IE a11y patch & clean up #25177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dreamofabear
commented
Oct 21, 2019
| } | ||
| tryFocus(internalElm); | ||
| } | ||
| } |
There was a problem hiding this comment.
AFAICT this was meant to handle hash navigation but it will never fire because the outer conditional specifically only passes on non-hash navigations.
|
/to @jridgewell |
dreamofabear
changed the title
jridgewell
approved these changes
Oct 22, 2019
joshuarrrr
pushed a commit
to Parsely/amphtml
that referenced
this pull request
Oct 22, 2019
micajuine-ho
pushed a commit
to micajuine-ho/amphtml
that referenced
this pull request
Dec 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly readability improvements, plus an important fix to make #19037 actually work.