Update I2I to include Launch tracker #25186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrjoro
approved these changes
Oct 22, 2019
|
@mrjoro I have changed the message inline based on @cramforce feedback to not make the process overwhelming. Could you take a look again? |
mrjoro
approved these changes
Oct 22, 2019
|
Merged! |
joshuarrrr
pushed a commit
to Parsely/amphtml
that referenced
this pull request
Oct 23, 2019
* Update I2I to include Launch tracker * Make the intention for launch tracker clearer.
micajuine-ho
pushed a commit
to micajuine-ho/amphtml
that referenced
this pull request
Dec 27, 2019
* Update I2I to include Launch tracker * Make the intention for launch tracker clearer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Launch tracker can be found here: bit.ly/amp-launch-tracker
Open question:
Should this be linked to in the I2S as well (I think so)?