Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

鈾伙笍馃摉Rename methods in SsrTemplateHelper #25241

Merged
merged 2 commits into from Oct 24, 2019

Conversation

caroqliu
Copy link
Contributor

Previous naming was confusing and potentially misleading.

src/ssr-template-helper.js Show resolved Hide resolved
Copy link
Contributor

@cathyxz cathyxz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SHIPIT xD
I am so in favor of this change lol.

@caroqliu caroqliu merged commit bc78cc2 into ampproject:master Oct 24, 2019
@caroqliu caroqliu deleted the ssr branch October 24, 2019 18:23
micajuine-ho pushed a commit to micajuine-ho/amphtml that referenced this pull request Dec 27, 2019
* SsrTemplateHelper method rename and comments

* Comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants