馃彈 Allow amphtml-validator to be used with node v8
#25278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rsimha
requested review from
twifkak,
Gregable,
honeybadgerdontcare and
estherkim
estherkim
approved these changes
Oct 28, 2019
honeybadgerdontcare
approved these changes
Oct 28, 2019
|
Verified that
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes it so that
amphtml-validatorcan be used withnodev8. This will need to be followed up with a new1.0.29release.Partial mitigation for #25209
Related to #25161 (comment)
/cc @ampproject/wg-caching