Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

πŸ“¦ Update dependency @percy/agent to v0.19.3 #25290

Merged
merged 1 commit into from Oct 29, 2019

Conversation

renovate-bot
Copy link
Contributor

@renovate-bot renovate-bot commented Oct 28, 2019

This PR contains the following updates:

Package Type Update Change
@percy/agent devDependencies patch 0.19.1 -> 0.19.3

Release Notes

percy/percy-agent

v0.19.3

Compare Source

Bug Fixes

v0.19.2

Compare Source

Bug Fixes

Renovate configuration

πŸ“… Schedule: At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻️ Rebasing: Whenever PR becomes conflicted, or if you modify the PR title to begin with "rebase!".

πŸ”• Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot. View repository job log here.

@amp-owners-bot
Copy link

Hey @danielrozenberg, these files were changed:

  • build-system/tasks/visual-diff/package.json
  • build-system/tasks/visual-diff/yarn.lock

1 similar comment
@amp-owners-bot
Copy link

Hey @danielrozenberg, these files were changed:

  • build-system/tasks/visual-diff/package.json
  • build-system/tasks/visual-diff/yarn.lock

@renovate-bot renovate-bot changed the title πŸ“¦ Update dependency @percy/agent to v0.19.2 πŸ“¦ Update dependency @percy/agent to v0.19.3 Oct 28, 2019
@renovate-bot renovate-bot changed the title πŸ“¦ Update dependency @percy/agent to v0.19.3 πŸ“¦ Update dependency @percy/agent to v0.19.3 Oct 28, 2019
Copy link
Contributor

@rsimha rsimha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@danielrozenberg, this version contains some startup / shutdown fixes that might be worth looking at, in case it allows our code to be simplified.

@rsimha rsimha merged commit 7c6745d into ampproject:master Oct 29, 2019
@renovate-bot renovate-bot deleted the renovate/percy-agent-0.x branch October 29, 2019 00:04
@danielrozenberg
Copy link
Member

Looked at the patch, doesn't seem like it's relevant to how we use it

@rsimha
Copy link
Contributor

rsimha commented Oct 29, 2019

Looked at the patch, doesn't seem like it's relevant to how we use it

I was talking about percy/percy-agent#403, which I believe led to your having to change the way processes are started / stopped in build-system/common/exec.js.

@danielrozenberg
Copy link
Member

That's the patch I was looking at

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants