New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ban amp-state in Mustache template output #25323
Conversation
@rcebulko clicking the owners details link just gives me a bunch of links and not why this failed. Would it be possible for it to say x, y or z did not approve this yet? |
This is for consistency with amp-list and amp-form: we don't allow XHR-firing components to be nested under another XHR-firing template.
I'm not sure exactly what you're asking. Does the details link not show you this? It lists the files in the PR needing approval and says who could approve it. What do you suggest adding? |
It does not. Clicking the |
@choumx for owners approval |
This is for consistency with amp-list and amp-form: we don't allow XHR-firing components to be nested under another XHR-firing template.
This is for consistency with amp-list and amp-form: we don't allow
XHR-firing components to be nested under another XHR-firing template.
/to @choumx