Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🏗 Remove deprecated and unused PERCY_PROJECT env variable from visual diff code #25341

Merged
merged 4 commits into from Oct 31, 2019
Merged

🏗 Remove deprecated and unused PERCY_PROJECT env variable from visual diff code #25341

merged 4 commits into from Oct 31, 2019

Conversation

danielrozenberg
Copy link
Member

Splitting off from #25335

estherkim
estherkim approved these changes Oct 30, 2019
View reviewed changes
Copy link
Collaborator

@estherkim estherkim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we remove PERCY_PROJECT from TESTING.md too?

@danielrozenberg
Copy link
Member Author

Done!

rsimha
rsimha approved these changes Oct 30, 2019
View reviewed changes
contributing/TESTING.md Outdated Show resolved Hide resolved
@rcebulko rcebulko self-requested a review October 31, 2019 14:59
@danielrozenberg danielrozenberg merged commit 8b97bc2 into ampproject:master Oct 31, 2019
@danielrozenberg danielrozenberg deleted the visual-diff-percy-update branch October 31, 2019 15:05
micajuine-ho pushed a commit to micajuine-ho/amphtml that referenced this pull request Dec 27, 2019
@danielrozenberg
🏗 Remove deprecated and unused PERCY_PROJECT env variable from visual…
5a4f8b0 
… diff code (ampproject#25341)

* Remove deprecated and unused PERCY_PROJECT env variable

* Update TESTING.md

* Grammar

* prettify
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rcebulko rcebulko rcebulko approved these changes

@rsimha rsimha rsimha approved these changes

@estherkim estherkim estherkim approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@danielrozenberg @rcebulko @rsimha @estherkim @googlebot