Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🏗🚀 Enable concurrency for multi-pass gulp dist on Travis #25373

Merged
merged 1 commit into from Nov 1, 2019
Merged

🏗🚀 Enable concurrency for multi-pass gulp dist on Travis #25373

merged 1 commit into from Nov 1, 2019

Conversation

rsimha
Copy link
Contributor

@rsimha rsimha commented Nov 1, 2019

Travis recently upgraded us to premium VMs on a trial basis. This PR experiments with increased concurrency for multi-pass gulp dist on Travis. Let's see what performance increase we get as a result of this.

@estherkim
Copy link
Collaborator

Just curious, what are premium VMs?

@rsimha
Copy link
Contributor Author

rsimha commented Nov 1, 2019

Just curious, what are premium VMs?

This isn't documented. I had to reach out to Travis to ask :)

Regular: 7.5 GB of RAM and 2 cores
Premium: 15 GB of RAM and 4 cores

Looks like the combination of premium VMs + increased concurrency has lowered the running time of multi-pass gulp dist from ~10 mins to ~5 mins.

I'll ask about making our upgrade permanent before merging this PR.

@estherkim
Copy link
Collaborator

Nice, that would be awesome.

@rsimha
Copy link
Contributor Author

rsimha commented Nov 1, 2019

Yay, we're upgrading to premium. I'll merge this PR once tests are green.

@rsimha rsimha merged commit 7288a3d into ampproject:master Nov 1, 2019
@rsimha rsimha deleted the 2019-11-01-ParallelDist branch November 1, 2019 23:58
micajuine-ho pushed a commit to micajuine-ho/amphtml that referenced this pull request Dec 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants