Used cached doc position in getLayoutRect. #2547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Does this address #2424? |
|
@mkhatib Nope that is separate, but good question! |
| const scrollTop = this.getScrollTop(); | ||
| const scrollLeft = this.getScrollLeft(); | ||
| getLayoutRect(el, opt_scrollLeft, opt_scrollTop) { | ||
| const scrollTop = opt_scrollTop || this.getScrollTop(); |
There was a problem hiding this comment.
Do you want to do this on 0?
|
LGTM |
This showed up benchmarking real world docs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This showed up benchmarking real world docs.