✨Allow custom text in ASAA CTA #25523
Conversation
|
@lannka @powerivq friendly ping :) cc/ @katrinivini |
| this.measurer_ = this.doc_.createElement('div'); | ||
|
|
||
| /** @private {number} Fixed button height from design spec. */ | ||
| this.maxHeight_ = 32; |
There was a problem hiding this comment.
Is this always fixed? Should it defined as a constant?
| maxFontSize | ||
| ) { | ||
| maxFontSize++; | ||
| // Binomial search for the best font size. |
There was a problem hiding this comment.
I think it should be
s/Binomial/Binary/
There was a problem hiding this comment.
Removed with the fit logic changes.
| * @param {number} maxFontSize | ||
| * @return {number} | ||
| */ | ||
| function calculateFontSize( |
There was a problem hiding this comment.
Is this for future proofing? The current range is very small at 12-14
There was a problem hiding this comment.
Good idea, refactored to start at 14 and work down
There was a problem hiding this comment.
A bit detailed, but I think a for loop would be more readable.
There was a problem hiding this comment.
changed to for loop.
| * @param {number} maxFontSize | ||
| * @return {number} | ||
| */ | ||
| function calculateFontSize( |
There was a problem hiding this comment.
A bit detailed, but I think a for loop would be more readable.
* works but not handling async * async all the things * fix types * fix auto ad tests * fix page tests * new tests * fix e2e * remove binary search * move max height * use for loop
Previously we only allowed CTA text from predefined choices, this allows ads to have custom text.
The new behavior is that the button will grow horizontally to fit the new variable text length. If the text is too long to fit within the design spec, the ad will be discarded.