✨📈 Add analytics trigger for elements that show a tooltip #25547
Conversation
| if ( | ||
| tagName && | ||
| pageDetails['tagName'] && | ||
| tagName.toLowerCase() !== pageDetails['tagName'] |
There was a problem hiding this comment.
Also .toLowerCase() the pageDetails one
There was a problem hiding this comment.
I am doing that on the updateDetails method in story-analytics.js when reading the element. Would you prefer it to be here instead?
Enriqe
force-pushed
the
analytics-triggers1
branch
from
7fc3bc5
to
ae19421
Compare
| @@ -104,15 +114,43 @@ <h1>Page Two</h1> | |||
| <amp-story-page id="p3"> | |||
| <amp-story-grid-layer template="vertical"> | |||
| <h1>Page Three</h1> | |||
| <a href="google.com">click me</a> | |||
There was a problem hiding this comment.
I'm not sure that I understand. But in your example, you are listening the story-focus/story-click-through event of all anchor tag. Do all anchor tag fire these two events, or it is only anchor tag created by embedded components and affiliate links?
Would this anchor tag fire those two events? Thanks
There was a problem hiding this comment.
Only anchor tags created by embedded components and affiliate links will fire this event, since they are the only type of anchor tags that will show a tooltip in stories currently
There was a problem hiding this comment.
Yuxuan makes a good point here, what prevents this link within a grid-layer to trigger the regular click analytics event? Since it has custom events, it should not trigger this default "click". Wdyt?
There was a problem hiding this comment.
Sounds good, I added a stopPropagation() where appropriate so that these will only be handled by our custom events, and not by the regular click analytics event.
|
Friendly ping @zhouyx |
| this.tooltip_.addEventListener( | ||
| 'click', | ||
| () => | ||
| this.analyticsService_.triggerEvent( |
There was a problem hiding this comment.
Do we need to stop propagation here as well?
There was a problem hiding this comment.
Hmm not for now since it's inside a shadow root. It won't be recognized by the selector. If we were to support selector inside a shadow root then we would have to do that. I'll just add it, just in case :) PTAL
Enriqe
force-pushed
the
analytics-triggers1
branch
from
7d11305
to
b3853c9
Compare
|
Thanks @zhouyx! Good points about the variable names |
…#25547) * support for focused and click thru states * support affiliate links * types * stop propagation on click events within affiliate links and embedded components * add stop propagation in tooltip click * renaming
|
@Enriqe is there any documentation available for this implementation. It will be very helpful. Thanks! |
Closes #25545
Closes #24122
Adds
story-focustrigger to track whenever an element that opens a tooltip is clicked andstory-click-throughwhenever a tooltip is clicked.It also adds support for using
tagNameto target specific elements that can trigger the tooltip.If the overall implementation / idea looks good I will write the corresponding tests.