📦 Update dependency fetch-mock to v8

[renovate-bot]

This PR contains the following updates:

Package	Type	Update	Change
fetch-mock (source)	devDependencies	major	7.7.3 -> 8.0.0

---

Release Notes

wheresrhys/fetch-mock

v8.0.0

Compare Source

• implements ES modules
• hopefully resolves problems with babel-core clashes
• adds typescript types
• removes the UNMATCHED and MATCHED constants, and no longer exports fetchMock as a property, as well as the default, export
• only includes the whatwg-url polyfill in nodejs

---

Renovate configuration

📅 Schedule: At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻️ Rebasing: Whenever PR becomes conflicted, or if you modify the PR title to begin with "rebase!".

🔕 Ignore: Close this PR and you won't be reminded about this update again.

---

• If you want to rebase/retry this PR, check this box

---

Newsflash: Renovate has joined WhiteSource, and is now free for all use. Learn more or view updated terms and privacy policies.

[rsimha]

Seems like this is a breaking change because fetch-mock has changed from js to mjs.

https://travis-ci.org/ampproject/amphtml/jobs/611045026#L471

20 11 2019 17:16:47.183:ERROR [framework.browserify]: SyntaxError: 'import' and 'export' may appear only with 'sourceType: module' (3518:0) while parsing /home/travis/build/ampproject/amphtml/node_modules/fetch-mock/esm/client.mjs while parsing file: /home/travis/build/ampproject/amphtml/node_modules/fetch-mock/esm/client.mjs

/cc @ampproject/wg-ads and @taymonbeal, since fetch-mock is primarily used in test-amp-a4a.js and test-a4a-integration.js

[taymonbeal]

That's actually a different fetch-mock that's now deprecated. The third-party fetch-mock that's being upgraded here is depended on directly by describes.js and is used by other code.

I don't understand why this error is happening; it looks like some kind of problem with Browserify? Why doesn't Browserify just consume the module?

(Also, I've switched teams at Google and no longer work on this codebase.)

[rsimha]

That's actually a different fetch-mock that's now deprecated. The third-party fetch-mock that's being upgraded here is depended on directly by describes.js and is used by other code.

Aha, that explains the difference in usage.

I don't understand why this error is happening; it looks like some kind of problem with Browserify? Why doesn't Browserify just consume the module?

The fetch-mock package has become esm by default with v8. Importing the es5 alternative in describes.js still works. I've done this in 6ee6fdb.

(Also, I've switched teams at Google and no longer work on this codebase.)

Thanks for checking in here, and for the useful tip. 👍

[rsimha]

Adding @jridgewell to review the change to describes.js.

[forking-renovate]

PR has been edited

👷 This PR has received other commits, so Renovate will stop updating it to avoid conflicts or other problems. If you wish to abandon your changes and have Renovate start over you may click the "rebase" checkbox in the PR body/description.

[rsimha]

For posterity, here's the usage documentation for fetch-mock v8: http://www.wheresrhys.co.uk/fetch-mock/#usageimporting