Webediads : amp-ad submission #2562
Conversation
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
|
I signed it! |
|
@dvoytenko PTAL |
| /** Created by Webedia on 07/03/16 */ | ||
| export function webediads(global, data) { | ||
| checkData(data, ['site', 'page', 'position', 'query']); | ||
| validateDataExists(data, ['site', 'page', 'position', 'query']); |
There was a problem hiding this comment.
Just to confirm: all fields are mandatory, right?
There was a problem hiding this comment.
In particular, I'm asking because I believe validateDataExists would assert on empty data-query as in the example.
There was a problem hiding this comment.
Yes, all fields are mandatory, but data-query can be empty.
I will change that, in order to have more flexibility.
|
Looks great. I posted one question for
|
|
CLAs look good, thanks! |
|
We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm. |
|
CLAs look good, thanks! |
|
Hi @dvoytenko, |
|
Hi @dvoytenko, I'm sorry but I'm not sure to understand. We have only one commit with all files modified (5 files). The two others commits are just "merged with master" (in order to have the latest version on my forked version). If I try to squash my commit with older merge, this will create a tree completely broken (concerning my opinion). |
|
@Lith: Try |
|
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. |
Webediads - "amp-ad" submission for our internal ad serving system (Webedia SAS). - Implementation of a new call system with smallest init script - Full documentation for our team - Lenny faces support - Add "Webediads" into the list of supported ad-network
|
CLAs look good, thanks! |
|
Thanks for your help @jridgewell ! Hope everything looks great now :) |
|
Ping @dvoytenko. |
|
LGTM! Thanks! |
Webediads : amp-ad submission
No description provided.