New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🏗 Add APPROVERS.json to enable blocking bundle-size checks for extensions #25652
🏗 Add APPROVERS.json to enable blocking bundle-size checks for extensions #25652
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a couple comments but otherwise LGTM
Addressed your comments. Please take another look, wanna get this right :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice PR!
I've requested a few changes below. Mostly grammar nits, and one question about file formats.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM after one more comment 👍
wip - not yet being used because the bundle-size app needs to be updated to use it