Correct sandbox attribute browser support #25668
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`allow-popup-to-escape-sandbox` has been implemented in all major browsers: https://www.chromestatus.com/feature/5708368589094912
dreamofabear
approved these changes
Nov 27, 2019
|
It may be worth mentioning the status on Opera and UC Browser if those are as-of-yet supported still, since they are included in AMP Supported Browsers. |
caroqliu
approved these changes
Nov 27, 2019
Good catch! Opera does support it (since Opera just uses Blink), but it turns out that Edge doesn't support it according to caniuse.com. It's also unknown whether UC Browser supports it. I've updated the documentation to correct the facts instead of removing the mention of browser support. |
zhangsu
changed the title
caroqliu
approved these changes
Dec 2, 2019
caroqliu
pushed a commit
to caroqliu/amphtml
that referenced
this pull request
Dec 5, 2019
* Stop mentioning sandbox attribute browser support `allow-popup-to-escape-sandbox` has been implemented in all major browsers: https://www.chromestatus.com/feature/5708368589094912 * Update support for Edge and Opera
micajuine-ho
pushed a commit
to micajuine-ho/amphtml
that referenced
this pull request
Dec 27, 2019
* Stop mentioning sandbox attribute browser support `allow-popup-to-escape-sandbox` has been implemented in all major browsers: https://www.chromestatus.com/feature/5708368589094912 * Update support for Edge and Opera
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
allow-popups-to-escape-sandboxhas been implemented in all major browsers:Chrome, Firefox and Safari:
https://www.chromestatus.com/feature/5708368589094912
Opera:
https://dev.opera.com/blog/opera-33/
Edge:
https://caniuse.com/#search=allow-popups-to-escape-sandbox
/to @choumx