Create OWNERS for amp-access-poool #25671
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpettitt
requested review from
dvoytenko and
alanorozco
and removed request for
alanorozco
dvoytenko
suggested changes
Nov 20, 2019
| { | ||
| rules: [ | ||
| { | ||
| owners: [{name: 'dackmin'}, {name: 'dvoytenko'}, {name: 'jpettitt'}], |
There was a problem hiding this comment.
Should we use wg- group as an owner here?
There was a problem hiding this comment.
I don't think so because as we add wg members from different companies I don't think they should own each others code.
dvoytenko
approved these changes
Nov 21, 2019
dvoytenko
approved these changes
Nov 21, 2019
micajuine-ho
pushed a commit
to micajuine-ho/amphtml
that referenced
this pull request
Dec 27, 2019
* Create OWNERS * typo * formatting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.