✨ Add support for data-ad-host-channel to AdSense ads #25685
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdSense custom channels allow to track the performance of specific adunits and generate reports for each channel. AMP currently only supports the data-ad-channel attribute, which allows to specify one or more custom channels for a specific amp-ad element. Host channels are also available to AdSense Host account, these can be used to track the performance of ads across publishers. https://developers.google.com/adsense/host/adunits#custom-channels https://developers.google.com/adsense/host/faq/hostchannels This commit adds support for AdSense Host channels to both regular amp-ad and amp-auto-ads elements.
|
@tlong2 @jeffkaufman could you take a look at this pull request? |
tlong2
approved these changes
Dec 2, 2019
|
@jeffkaufman any feedback? @calebcordry some automatic test failed, however to me it doesn't look related to the changes introduced by the pull request. Should they be restarted? |
|
Restarted Travis. |
jeffkaufman
approved these changes
Jan 17, 2020
|
@CarloCannas Sorry for the delay over the holidays. Thanks for contributing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AdSense custom channels allow to track the performance of specific adunits and generate reports for each channel.
AMP currently only supports the data-ad-channel attribute, which allows to specify one or more custom channels for a specific amp-ad element.
Host channels are also available to AdSense Host account, these can be used to track the performance of ads across publishers.
https://developers.google.com/adsense/host/adunits#custom-channels
https://developers.google.com/adsense/host/faq/hostchannels
Currently AMP doesn't allow to specify an Host channel to
amp-adelements, this pull request adds support for thedata-ad-host-channelattribute to bothamp-adandamp-auto-adselements.